Typos 'conpute', 'allignof', and 'comput' in the comment. I'm not really a big fan of ASTContext knowing about the semantics of the GNU alignof extension like this, but the change looks correct. Changing the comment to talk about semantic alignment versus ABI alignment would help (but that doesn't cover the following-references / not-following-references half).
On Wed, Aug 7, 2013 at 8:19 PM, Rafael Espíndola <[email protected] > wrote: > >> To quote Clang, 'alignof' applied to an expression is a GNU extension. > >> Thus we should presumably do what GCC does -- C++ doesn't have a notion > of > >> the alignment of a declaration as distinct from the alignment of its > type. > > > > > > OK, so that's not strictly-speaking true, but it doesn't have a notion of > > the alignment being increased because all globals happen to be 16-byte > > aligned on the target system. > > The attached patch should fix it. Is it OK? > > Cheers, > Rafael >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
