On Thu, Aug 8, 2013 at 5:10 AM, Rafael Espíndola <[email protected] > wrote:
> On 8 August 2013 01:36, Richard Smith <[email protected]> wrote: > > Typos 'conpute', 'allignof', and 'comput' in the comment. > > Fixed. Looks like you're also missing an update to ASTContext.h to change the parameter name there? > I'm not really a big fan of ASTContext knowing about the semantics of the > > GNU alignof extension like this, but the change looks correct. Changing > the > > comment to talk about semantic alignment versus ABI alignment would help > > (but that doesn't cover the following-references / > not-following-references > > half). > > AST suffers from being the place we have for sharing code between Sema > and Codegen. As you point out, "semantic" would be a bit vague as what > we compute is specific to alignof. > I suspect we'll want to revisit this at some point, but LGTM for now.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
