Hi Howard, Sure. I've revised as follows.
Diffs: (See attached file: buildit.diffs) The actual file: (See attached file: buildit) However, the code in question does not seem to work to me. Notice libc+ +.so.1.0 is generated because of "-o libc++.so.1.0" in line 103. The 'ln -s libc++.so.1 libc++.so' command in line 141 will fail. That's why line 141 was changed to 'ln -s libc++.so.1.0" in the previous patch. I think the proper fix will be to change line 103 to "-o libc++.so.1" to be consistent with the soname. ... 100 *) 101 RC_CFLAGS="-fPIC" 102 SOEXT=so 103 LDSHARED_FLAGS="-o libc++.so.1.0 \ 104 -shared -nodefaultlibs -Wl,-soname,libc++.so.1 \ 105 -lpthread -lrt -lc -lstdc++" 106 ;; .... 139 *) 140 rm -f libc++.so 141 ln -s libc++.so.1 libc++.so 142 ;; Thanks, Xing Xue XLC++ Compiler Development / IBM Software Solutions Toronto Lab. Tie Line: 313-3972 Phone: 905-413-3972 Email: [email protected] |------------> | From: | |------------> >--------------------------------------------------------------------------------------------------------------------------------------------------| |Howard Hinnant <[email protected]> | >--------------------------------------------------------------------------------------------------------------------------------------------------| |------------> | To: | |------------> >--------------------------------------------------------------------------------------------------------------------------------------------------| |Xing Xue/Toronto/IBM@IBMCA | >--------------------------------------------------------------------------------------------------------------------------------------------------| |------------> | Cc: | |------------> >--------------------------------------------------------------------------------------------------------------------------------------------------| |"[email protected] cfe" <[email protected]>, David Chisnall <[email protected]>, Michael Wong/Toronto/IBM@IBMCA, | |"[email protected] Abdulrasool" <[email protected]>, Dimitry Andric <[email protected]>, "Andrew C. Morrow" <[email protected]>, | |[email protected], [email protected], "[email protected] Yasskin" <[email protected]> | >--------------------------------------------------------------------------------------------------------------------------------------------------| |------------> | Date: | |------------> >--------------------------------------------------------------------------------------------------------------------------------------------------| |08/14/2013 10:00 AM | >--------------------------------------------------------------------------------------------------------------------------------------------------| |------------> | Subject: | |------------> >--------------------------------------------------------------------------------------------------------------------------------------------------| |Re: [libc++] Patch for AIX port | >--------------------------------------------------------------------------------------------------------------------------------------------------| On Aug 14, 2013, at 3:45 AM, David Chisnall <[email protected]> wrote: >> rm -f libc++.so >> - ln -s libc++.so.1 libc++.so >> + ln -s libc++.so.1.0 libc++.so >> ;; >> esac >> >> All, please examine the last line: >> >> - ln -s libc++.so.1 libc++.so >> + ln -s libc++.so.1.0 libc++.so > > This does, however. We don't usually use a.b version numbers. It isn't of vital importance, however, as we don't use the upstream build system for the libc++ that we ship, although it would be mildly inconvenient for people who are building a newer version for testing. > > Oh, and ln -sf is generally better than rm then ln, as it allows the operation to be atomic. Xing, can you rework this part so that it is -ibm-only? Howard
<<inline: graycol.gif>>
<<inline: ecblank.gif>>
buildit.diffs
Description: Binary data
buildit
Description: Binary data
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
