generally lg

================
Comment at: clang-replace/ApplyReplacements.cpp:210
@@ +209,3 @@
+    if (!ErrorInfo.empty()) {
+      errs() << "Unable to open " << FileName << " for writing\n";
+      return false;
----------------
Since we're already using Diagnostics for everything else, might it make sense 
to use them here, too?


http://llvm-reviews.chandlerc.com/D1460

BRANCH
  apply_changes

ARCANIST PROJECT
  clang-tools-extra
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to