================
Comment at: clang-replace/ApplyReplacements.cpp:210
@@ +209,3 @@
+ if (!ErrorInfo.empty()) {
+ errs() << "Unable to open " << FileName << " for writing\n";
+ return false;
----------------
Edwin Vane wrote:
> Manuel Klimek wrote:
> > Since we're already using Diagnostics for everything else, might it make
> > sense to use them here, too?
> Actually, we're not actually using Diagnostics yet:) It's just passed around
> with the intention of using it. I have to look into how to do error reporting
> with a DiagnosticsEngine yet.
Perhaps you were referring to the lack of DiagnosticsEngine in the arg list?
The plan is to use `SourceManager::getDiagnostics()` instead.
http://llvm-reviews.chandlerc.com/D1460
BRANCH
apply_changes
ARCANIST PROJECT
clang-tools-extra
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
