On Aug 22, 2013, at 5:18 PM, G M <[email protected]> wrote:
> Hello Everyone, in particular Reid.
>
> This patch is a subset of a previous patch I sent. You asked to separate that
> patch out to make it easier for you to review.
>
> This is the non contentious part of that patch which you described as
> "obvious goodness".
This bit:
namespace { // Private
struct free_deleter {
inline void operator()(char* p) { free(p); }
};
}
I would write as:
struct __free_deleter {
inline void operator() (char* p) const noexcept { free(p); }
};
i.e, ditch the namespace, prepend the name with __ and, mark const and noexcept.
-- Marshall
Marshall Clow Idio Software <mailto:[email protected]>
A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly
moderated down to (-1, Flamebait).
-- Yu Suzuki
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
