Hi Argyrios, I meant to list you as a reviewer for this also, but I couldn't find you in Phabricator. So if you have any feedback too, I'd appreciate it, since you suggested I write more tests for PPCallbacks.
Thanks. -John -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of John Thompson Sent: Thursday, October 17, 2013 4:13 PM To: [email protected]; [email protected] Cc: [email protected] Subject: [PATCH] PPCallbacksTest expansion - part 1 Hi kimgr, This patch implements a test mechanism for the PPCallbacks mechanism that I've added to the existing tests. It's based on creating a derivation of PPCallbacks that records information passed to each callback in a high-level string format, for later comparison against an array of expected patterns. It allows testing of both the callback order as well as the callback argument content. This patch provides the basic mechanism, but only implements two new test functions using it, for just the macro-based and conditional-based callbacks, as a proof of concept. If you approve this basic mechanism, I will add additional tests covering other callbacks and situations in subsequent patches. http://llvm-reviews.chandlerc.com/D1966 Files: PPCallbacksTest.cpp _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
