Hi Rafael, The changes are to bring clang inline with the current llvm-gcc port for XCore. Hence, WCharType is an unsigned 8bit and WIntType is a signed 32bit.
I believe the test already in test/Preprocessor/stdint.c cover the other cases. This does lead to question why the change was needed. It just seemed a good idea to make them explicit. Could you advise what I should have done please. Thank you Robert ________________________________________ From: Rafael Espíndola [[email protected]] Sent: 04 November 2013 15:35 To: Robert Lytton Cc: [email protected] Subject: Re: XCore target Type defines Is Xcode the only system with a 8 byte wchar? Is that valid according to the standard? You are changing 5 types (SizeType, PtrDiffType, IntPtrType, WCharType, WIntType) but only updating tests for 2. Why? On 21 October 2013 02:17, Robert Lytton <[email protected]> wrote: > Hi > Is this good to go? > Thank you. > Robert > ________________________________ > From: [email protected] [[email protected]] on > behalf of Robert Lytton [[email protected]] > Sent: 16 October 2013 17:06 > To: [email protected] > Subject: XCore target Type defines > > Hi, > > Here is a patch to change SizeType, PtrDiffType, IntPtrType, WCharType, > WIntType > for the xcore target so they are the same as the XMOS llvm-gcc front end's > settings! > > Robert > > > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
