On 4 November 2013 08:55, Robert Lytton <[email protected]> wrote: > Hi Rafael, > > The changes are to bring clang inline with the current llvm-gcc port for > XCore. > Hence, WCharType is an unsigned 8bit and WIntType is a signed 32bit.
OK. > I believe the test already in test/Preprocessor/stdint.c cover the other > cases. > This does lead to question why the change was needed. > It just seemed a good idea to make them explicit. > Could you advise what I should have done please. Please double check that there are tests. If the patch is just making it explicit, that is fine. If not, please add the missing tests. LGTM with that. Cheers, Rafael _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
