================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:1690 @@ -1684,1 +1689,3 @@ + TemplateSpecializationType), + false>(InnerMatcher); } ---------------- Samuel Benzaquen wrote: > Manuel Klimek wrote: > > /*EnableCompileTimeChecks=*/false > > (here and elsewhere) > > > > On the other hand, I'm not sure I like this (and I've gone back and forth > > on that detail myself ;) > > There's some principal beauty to being able to use all nodes that have > > getDecl() in hasDeclaration. On the other hand, the further down we push > > the error checks, the worse the error messages for our users. Due to how > > bad template error messages still are, this is one of the largest problems > > we have today. The dynamic matchers will hopefully get some of that out of > > the way, but I still believe that for now we just want to spell out all the > > types it's callable on. > Do you have a such a list? > From the implementation of HasDeclarationMatcher is not obvious. Fixed the bool problem.
http://llvm-reviews.chandlerc.com/D1889 BRANCH has_decl ARCANIST PROJECT clang _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
