Thanks both - original change + refactoring commited as r197151-4. Tim, no worries about the delay. I could've driven it harder, and the discusson about targets/driver design was educational.
Regards, Bernie > -----Original Message----- > From: Jim Grosbach [mailto:[email protected]] > Sent: 12 December 2013 02:45 > To: Bernard Ogden > Cc: Renato Golin; reviews+D2243+public+6ca39a6218cf2957@llvm- > reviews.chandlerc.com; [email protected]; Tim Northover > Subject: Re: [PATCH] Refactor duplicate functions > > Since Tim's OK with it, that's good enough for me. If there are any > problems, we can sort it out post-commit. > > Thanks! > -Jim > > On Dec 11, 2013, at 5:54 AM, Tim Northover <[email protected]> > wrote: > > >> I think the patch is good, if not pretty, so I'd like to commit. Can > anyone > >> comment on whether the tests are enough to guarantee preservation of > the > >> existing Darwin behaviour? > > > > I think they looks reasonable. They cover the things I care about at > > the moment anyway. I think you should go for it. (And very sorry for > > the long delay in getting this committed. I know it wasn't exactly > > your idea in the first place). > > > > Cheers. > > > > Tim. > _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
