I think all the test/CodeGen* changes are good, and should probably land now.

  The test/CXX and test/SemaCXX changes should probably be reviewed separately 
by Richard.


================
Comment at: test/CXX/drs/dr2xx.cpp:543
@@ -542,3 +542,3 @@
   struct C : A, B {
-    virtual ~C();
+    virtual ~C(); // expected-error 0-1 {{'operator delete' found in multiple 
base classes}}
   };
----------------
So, I remember we decided to do it this way, but now we've essentially weakened 
this test to pass if we fail to diagnose this in the Itanium C++ ABI.  Can you 
remind me what the issue is here?  This has to do with differing operator 
delete lookup behavior?


http://llvm-reviews.chandlerc.com/D2401
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to