LGTM I'd still be interested in us pursuing two things: 1) Don't access-check the dtor call for a by-val parameter (D2409), and 2) Don't perform `operator delete` lookup when we see a virtual dtor declaration, instead perform it when we see a dtor definition or a use of the vtable.
But those don't have to happen before this lands. ================ Comment at: test/SemaCXX/virtual-base-used.cpp:1-2 @@ -1,2 +1,3 @@ -// RUN: %clang_cc1 -fsyntax-only -verify %s +// RUN: %clang_cc1 -fsyntax-only -cxx-abi itanium -verify %s +// RUN: %clang_cc1 -fsyntax-only -cxx-abi microsoft -DMSABI -verify %s // PR7800 ---------------- Please add a comment somewhere in this test explaining that we need to do different things for MSVC versus Itanium because MSVC doesn't have key functions. ================ Comment at: test/SemaCXX/warn-weak-vtables.cpp:2 @@ -2,1 +1,3 @@ +// RUN: %clang_cc1 %s -fsyntax-only -verify -cxx-abi itanium -Wweak-vtables -Wweak-template-vtables +// RUN: %clang_cc1 %s -fsyntax-only -cxx-abi microsoft -Wno-weak-vtables -Wno-weak-template-vtables ---------------- Maybe `-Werror` here? Otherwise I'm not sure what the `-Wno-weak-*` are for. ================ Comment at: test/SemaTemplate/instantiate-exception-spec-cxx11.cpp:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -ftemplate-depth 16 -fcxx-exceptions -fexceptions %s +// RUN: %clang_cc1 -fsyntax-only -verify -cxx-abi itanium -std=c++11 -ftemplate-depth 16 -fcxx-exceptions -fexceptions %s ---------------- Please add a comment saying that this test is Itanium-specific because it depends on key functions in namespace PR12763 (maybe as a FIXME). http://llvm-reviews.chandlerc.com/D2401 _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
