You should wait for an explicit ack on committing a patch if it's in review. It's a bit anti-social to do so otherwise and that people are waiting isn't a good enough reason to skip that.
In addition, asking you to improve the comments was a way of getting a better explanation of the code without having it tied up in email - if I have to ask then so would someone else. I may have other feedback for you after the comments are added. -eric On Mon Jan 06 2014 at 2:36:28 PM, Justin Bogner <[email protected]> wrote: > Justin Bogner <[email protected]> writes: > > Since we're basically just improving comments at this point, and since > > this not being in has been blocking other people trying to use and > > build on top of these changes, I'm going to go ahead and commit > > now. I'll continue to incorporate further feedback in follow on > > commits. > > r198638, r198639, and r198640. > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
