Jordan, thanks for working!
And I am sorry I mis-introduced dependent libraries despite of plugin module.

FYI, I woked llvm_add_library(MODULE) would be semantically equivalent
to add_llvm_loadable_module.


> ==============================================================================
> --- cfe/trunk/examples/analyzer-plugin/CMakeLists.txt (original)
> +++ cfe/trunk/examples/analyzer-plugin/CMakeLists.txt Wed Feb 12 15:04:23 2014
> @@ -1,8 +1,4 @@
> -set(LLVM_LINK_COMPONENTS
> -  Support
> -  )
> -
> -add_clang_library(SampleAnalyzerPlugin MODULE MainCallChecker.cpp)
> +add_llvm_loadable_module(SampleAnalyzerPlugin MainCallChecker.cpp)
>
>  add_dependencies(SampleAnalyzerPlugin
>    ClangAttrClasses
> @@ -11,15 +7,7 @@ add_dependencies(SampleAnalyzerPlugin
>    ClangDeclNodes
>    ClangDiagnosticCommon
>    ClangStmtNodes
> -  )
> -
> -target_link_libraries(SampleAnalyzerPlugin
>    clangAST
>    clangAnalysis
>    clangStaticAnalyzerCore
>    )

One-point nitpick; Did you really need to add dependencies to these libraries?
I guess you would like ClangCommentCommandList here.

I will prune whole them soon.

> -
> -set_target_properties(SampleAnalyzerPlugin
> -  PROPERTIES
> -  LINKER_LANGUAGE CXX
> -  PREFIX "")
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to