On Feb 13, 2014, at 7:57 , NAKAMURA Takumi <[email protected]> wrote:
> One-point nitpick; Did you really need to add dependencies to these libraries? I thought about this. Since we don't link to any of these libraries, we shouldn't need them. But then I thought we'd want to recompile this plugin if any of them changed. However, today I realized CMake should already be looking at the header files as dependencies (by scanning includes), so I can probably drop them. > I guess you would like ClangCommentCommandList here. Good point. This is the template for any future checker plugins, including ones that look at comments. I'll fix both of these issues. Thanks! Jordan
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
