On Fri, 2014-02-21 at 10:02 -0500, Rafael Espíndola wrote: > > OK, this is going a bit off topic for this code review. What this > patch does is disable the integrated assembler completely when > -no-integrated-as is given. Both for -S and -c. I think you agree that > that is the correct behavior.
Yes, it's a good start. > Another possible change would be for the driver to make -S imply > -no-integrated assembler. That is far more contentious and should have > a code review of its own. Agreed. I think the idea of checking for missing constraints is a good one, but unless you do make '-S' disable it completely, it's very important to have a non-catastrophic failure mode. If 'clang -S' can't parse the inline asm, then it should just silently decline to check for missing constraints, or do the other cool things you suggested. It should *not* break the build as seen in bug 18891. I'd accept the failure mode being fixed, instead of completely disabling the feature when -S is used. -- dwmw2
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
