Hi Nico, Are you upgrading a warning to an error, or are you adding a new error? In the patch I do not see that you are removing the old warning. - Gao
________________________________________ From: [email protected] [[email protected]] on behalf of Reid Kleckner [[email protected]] Sent: Wednesday, February 26, 2014 10:55 AM To: Nico Rieck Cc: [email protected] cfe Subject: Re: [PATCH] Sema: Definition of dllimport globals is not allowed LGTM, thanks! On Wed, Feb 26, 2014 at 2:49 AM, Nico Rieck <[email protected]<mailto:[email protected]>> wrote: On 22.02.2014 21:07, Nico Rieck wrote: > This upgrades the warning when defining dllimport variables to an error > (consistent with GCC and MSVC). Ping. _______________________________________________ cfe-commits mailing list [email protected]<mailto:[email protected]> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
