On 26.02.2014 20:01, Gao, Yunzhong wrote: > Hi Nico, > Are you upgrading a warning to an error, or are you adding a new error? In > the patch I do not see that you are removing the old > warning.
It upgrades how we diagnose this issue. And the previous warning is a generic one which is also used elsewhere. > It looks like you do not have to use two if statements here since ImportAttr > is not referenced? > Maybe if (VDecl->hasAttr<DLLImportAttr>() && !VDecl->isStaticDataMember()) > will suffice. I'll simplify it, thanks! -Nico _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
