On Thu, Apr 03, 2014 at 01:41:59PM +0800, Jiangning Liu wrote: > Hi Tom, > > Please refer to attached abi-compliance-checker report for those patches > I'm asking for back porting to 3.4.1. > > Test Results > ------------------------------ > Total Header Files882 <#Headers>Total Shared Libraries2 <#Libs>Total > Symbols / Types5491 / 2756Verdict > > *Incompatible(0.1%)* > > So the backward compatibility is 99.9%, and I don't see big issues.
The compatibility needs to be 100%, and in this case I know that changing the Intrinsic enum will cause problems, because I also changed this enum when preparing R600 patches for distros to apply on top of LLVM 3.3 and it broke Ubuntu's clang package. I can see three solutions to this problem (in order of preference) 1. Rename the intrinsics so that they end up at the bottom of the list. These are only accessed via clang builtins, so the names should matter, right? 2. Don't generate the intrinsic enum at buildtime. Generate it once offline and check it in and then modify the build system to use this copy. 3. Don't add these intrinsics. Also, before we get too far into this, I would really like to get approval from Tim Northover (AArch64 code owner) and Evan Cheng (ARM code owner) for merging these patches. Can you ping them and ask them to reply on list with their response. Thanks, Tom > > Thanks, > -Jiangning > > > 2014-04-02 23:36 GMT+08:00 Tom Stellard <[email protected]>: > > > On Wed, Apr 02, 2014 at 03:38:18PM +0100, Tim Northover wrote: > > > Hi Renato, > > > > > > > Apart from this one, I don't see any problem with the merges regarding > > > > ABI compatibility. > > > > > > I think Tom meant ABI compatibility in the libLLVMWhatever.so > > > libraries (and headers) rather than generated code. The 3.4.1 binaries > > > should be drop-in replacements for whatever systems we produce. > > > > > > > Yes, I was talking about LLVM's library ABI compatibility with 3.4.0 > > rather AARCH64 ABI compatibility. > > > > -Tom > > _______________________________________________ > > cfe-commits mailing list > > [email protected] > > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > > > > > > -- > Thanks, > -Jiangning _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
