On Tue, Apr 22, 2014 at 4:54 PM, Tyler Nowicki <[email protected]> wrote:

> Please review this updated patch. It includes the changes we discussed.
> Thanks for all your input!
>

FWIW, I'm roughly happy with the syntax / naming direction this is heading
in.

You probably want someone more familiar with the Clang internals (AST,
pragma parsing) to review the patch in detail (Doug or Richard) but I'm
somewhat concerned about the multiple inheritance. I don't think that's
really the right way to put this into the AST, but it's been a while since
I was lats AST hacking. =]
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

Reply via email to