Thanks, I'll do that next time. Should I use that instead of git svn dcommit to push the change?
-Alex On Wed, Apr 30, 2014 at 7:58 AM, Alexander Kornienko <[email protected]>wrote: > On Wed, Apr 30, 2014 at 4:26 PM, Alex McCarthy <[email protected]> wrote: > >> ================ >> Comment at: test/clang-tidy/temporaries.cpp:3 >> @@ +2,3 @@ >> +// FileCheck complains if the input file is empty, so add a dummy line. >> +// RUN: echo foo >> %t.log >> +// RUN: FileCheck %s < %t.log >> ---------------- >> Alexander Kornienko wrote: >> > You don't need this now as the correct output is guaranteed to be >> non-empty. And you can now just pipe clang-tidy output to FileCheck >> Good catch: fixed in llvm-reviews.chandlerc.com/rL207653 >> >> http://reviews.llvm.org/D3556 >> >> > BTW, if you use Phabricator's arc tool, you can also use "arc commit", > which automatically closes the Differential revision in Phab. >
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
