LGTM, although this makes the "do this properly" FIXME seem somewhat more of a
pressing concern :)
================
Comment at: lib/CodeGen/CodeGenAction.cpp:405
@@ -403,4 +404,3 @@
Column = 1;
- Loc = SourceMgr.translateFileLineCol(FileMgr.getFile(Filename), Line,
- Column);
+ Loc = SourceMgr.translateFileLineCol(FE, Line, Column);
}
----------------
How does `SourceMgr` respond if the file/line you give it is out of range for
the file?
http://reviews.llvm.org/D3625
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
