On Wed, May 7, 2014 at 5:32 PM, Richard Smith <[email protected]> wrote:
> LGTM, although this makes the "do this properly" FIXME seem somewhat more > of a pressing concern :) > > Yeah. How depressing. I think I'll explore biting this particular bullet. Maybe it's not as horrible as I think. > ================ > Comment at: lib/CodeGen/CodeGenAction.cpp:405 > @@ -403,4 +404,3 @@ > Column = 1; > - Loc = SourceMgr.translateFileLineCol(FileMgr.getFile(Filename), > Line, > - Column); > + Loc = SourceMgr.translateFileLineCol(FE, Line, Column); > } > ---------------- > How does `SourceMgr` respond if the file/line you give it is out of range > for the file? > With a Loc that returns true for Loc.isInvalid(). In the test case I added, the #line directive is completely bogus. Diego.
_______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
