Any more comments on this?
On 13/05/14 17:09, Pedro Ferreira wrote:
Your wish is my command.
On 13/05/14 16:18, Joey Gouly wrote:
LGTM too, but please add a test case to invalid-kernel-attrs.cl.
-----Original Message-----
From: [email protected]
[mailto:[email protected]] On Behalf Of David Tweed
Sent: 13 May 2014 11:50
To: 'Pedro Ferreira'; [email protected]
Subject: RE: [PATCH] Clang: Reject OpenCL workgroup size requirement
of 0
The patch LGTM.
-----Original Message-----
From: [email protected]
[mailto:[email protected]] On Behalf Of Pedro Ferreira
Sent: 13 May 2014 10:03
To: [email protected]
Subject: [PATCH] Clang: Reject OpenCL workgroup size requirement of 0
OpenCL allows us to define the workgroup size used in a kernel in order
to further optimise the code, specifically to that size.
The syntax is
__attribute__((reqd_work_group_size(X, Y, Z)))
where X, Y and Z are compile-time known integers.
Currently clang allows any of those to be 0, which would be illegal in
OpenCL.
The attached patch adds this validation; it's currently a draft and any
comments would be welcome.
(I reported this on bug 19699)
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
