On 07/03/14 9:30 AM, Daniel Sanders wrote:
The test in the clang patch passes without the rest of the patch. I think you
need to add a check that -no-integrated-as isn't present in the sub-command.
> Other than that it LGTM. I'm happy to commit it for you once you've
fixed that
> bug.
Getting back to this. I don't understand why the test would be passing
without the rest of the patch. But I don't have much familiarity with
the test framework. Your suggestion does make more sense. Taking into
consideration my lack of familiarity with the framework can you make
a suggestion as to what I should change the test to?
// Check that the integrated assembler is enabld for PowerPC
// RUN: %clang -target powerpc-unknown-openbsd -### -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-POWERPC-AS %s
// CHECK-POWERPC-AS: clang{{.*}}" "-cc1" "-triple"
"powerpc-unknown-openbsd" "-emit-obj"
$ clang -target powerpc-unknown-openbsd -### -c foo.c
clang version 3.5 (trunk)
Target: powerpc-unknown-openbsd
Thread model: posix
"/usr/local/bin/clang-3.5" "-cc1" "-triple" "powerpc-unknown-openbsd"
"-emit-obj" "-mrelax-all" "-disable-free" "-disable-llvm-verifier"
"-main-file-name" "foo.c" "-mrelocation-model" "pic" "-pic-level" "2"
"-pie-level" "2" "-mdisable-fp-elim" "-masm-verbose"
"-mconstructor-aliases" "-target-cpu" "ppc" "-coverage-file"
"/home/brad/foo.o" "-resource-dir" "/usr/local/bin/../lib/clang/3.5"
"-fdebug-compilation-dir" "/home/brad" "-ferror-limit" "19"
"-fmessage-length" "205" "-stack-protector" "2" "-mstackrealign"
"-fno-signed-char" "-fobjc-runtime=gnustep" "-fdiagnostics-show-option"
"-vectorize-slp" "-o" "foo.o" "-x" "c" "foo.c"
$ clang -target powerpc-unknown-openbsd -no-integrated-as -### -c foo.c
clang version 3.5 (trunk)
Target: powerpc-unknown-openbsd
Thread model: posix
"/usr/local/bin/clang-3.5" "-cc1" "-triple" "powerpc-unknown-openbsd"
"-S" "-disable-free" "-disable-llvm-verifier" "-main-file-name" "foo.c"
"-mrelocation-model" "pic" "-pic-level" "2" "-pie-level" "2"
"-mdisable-fp-elim" "-masm-verbose" "-no-integrated-as"
"-mconstructor-aliases" "-target-cpu" "ppc" "-coverage-file"
"/tmp/foo-fc5ab8.s" "-resource-dir" "/usr/local/bin/../lib/clang/3.5"
"-fno-dwarf-directory-asm" "-fdebug-compilation-dir" "/home/brad"
"-ferror-limit" "19" "-fmessage-length" "205" "-stack-protector" "2"
"-mstackrealign" "-fno-signed-char" "-fobjc-runtime=gnustep"
"-fdiagnostics-show-option" "-vectorize-slp" "-o" "/tmp/foo-fc5ab8.s"
"-x" "c" "foo.c"
"/usr/bin/as" "-mppc" "-many" "-o" "foo.o" "/tmp/foo-fc5ab8.s"
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
