On 12/06/14 12:26 AM, Brad Smith wrote:
On 07/03/14 9:30 AM, Daniel Sanders wrote:
The test in the clang patch passes without the rest of the patch. I
think you
need to add a check that -no-integrated-as isn't present in the
sub-command.
> Other than that it LGTM. I'm happy to commit it for you once you've
fixed that
> bug.
Getting back to this. I don't understand why the test would be passing
without the rest of the patch. But I don't have much familiarity with
the test framework. Your suggestion does make more sense. Taking into
consideration my lack of familiarity with the framework can you make
a suggestion as to what I should change the test to?
// Check that the integrated assembler is enabld for PowerPC
// RUN: %clang -target powerpc-unknown-openbsd -### -c %s 2>&1 \
// RUN: | FileCheck -check-prefix=CHECK-POWERPC-AS %s
// CHECK-POWERPC-AS: clang{{.*}}" "-cc1" "-triple"
"powerpc-unknown-openbsd" "-emit-obj"
Looking at some of the other tests for inspiration I'm wondering
if this would be enough...
// CHECK-POWERPC-AS-NOT: "-no-integrated-as"
??
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
