----- Original Message ----- > From: "Pekka Jääskeläinen" <[email protected]> > To: "Mark Heffernan" <[email protected]> > Cc: [email protected], "cfe-commits" <[email protected]> > Sent: Tuesday, June 24, 2014 5:31:56 AM > Subject: Re: [PATCH] Change loop unroll and vectorizer metadata prefix to > 'llvm.loop.' > > Hi, > > LGTM. One thing though: If one of the renamed metadatas was there > already in LLVM 3.4, I think it's polite for > out-of-tree projects (that might refer to the metadata by name) to > have this rename mentioned in the 3.5 release notes.
Moreover, for metadata that was supported by the 3.4 release, autoupgrade support should be added. Please do this before you commit. -Hal > > On Tue, Jun 24, 2014 at 12:30 AM, Mark Heffernan <[email protected]> > wrote: > > These patches rename the loop unrolling and loop vectorizer > > metadata > > such that they have a common 'llvm.loop.' prefix. Metadata name > > changes: > > > > llvm.vectorizer.* => llvm.loop.vectorizer.* > > llvm.loopunroll.* => llvm.loop.unroll.* > > > > This was a suggestion from an earlier review > > (http://reviews.llvm.org/D4090) which added the loop unrolling > > metadata. Two patches are attached. One for front-end and one for > > optimizer. > > > > Mark > > > > -- > --PJ > _______________________________________________ > cfe-commits mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits > -- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
