Thanks for the comments. I'll add something to the release notes. On Tue, Jun 24, 2014 at 3:52 AM, Hal Finkel <[email protected]> wrote: > Moreover, for metadata that was supported by the 3.4 release, autoupgrade > support should be added. Please do this before you commit.
By autoupgrade do you mean be permissive about what is accepted? That is, accept llvm.vectorizer.* and llvm.loop.vectorizer.* but only emit the llvm.loop form from the FE. Or do you mean try to rename the metadata as soon as it parsed? I can see how to do the first case (be permissive) easily, but for the second (rename metadata) do you have any suggestions for the best place to cut in (I'm fairly new to the code base)? Thanks! Mark > > -Hal > >> >> On Tue, Jun 24, 2014 at 12:30 AM, Mark Heffernan <[email protected]> >> wrote: >> > These patches rename the loop unrolling and loop vectorizer >> > metadata >> > such that they have a common 'llvm.loop.' prefix. Metadata name >> > changes: >> > >> > llvm.vectorizer.* => llvm.loop.vectorizer.* >> > llvm.loopunroll.* => llvm.loop.unroll.* >> > >> > This was a suggestion from an earlier review >> > (http://reviews.llvm.org/D4090) which added the loop unrolling >> > metadata. Two patches are attached. One for front-end and one for >> > optimizer. >> > >> > Mark >> >> >> >> -- >> --PJ >> _______________________________________________ >> cfe-commits mailing list >> [email protected] >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits >> > > -- > Hal Finkel > Assistant Computational Scientist > Leadership Computing Facility > Argonne National Laboratory _______________________________________________ cfe-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
