Thanks!
================
Comment at: src/Unwind/Unwind-EHABI.cpp:110
@@ -108,3 +109,3 @@
// Clear off flag from last bit.
- length &= ~1;
- offset &= ~1;
+ length &= ~(uint32_t)0x1;
+ offset &= ~(uint32_t)0x1;
----------------
No need for the 0x
Also, since we know this is always 32bit code, you can just write ~1u
(everywhere)
================
Comment at: src/Unwind/Unwind-EHABI.cpp:213
@@ -211,3 +212,3 @@
uint32_t RegisterRange(uint8_t start, uint8_t count_minus_one) {
- return (start << 16) | (count_minus_one + 1);
+ return ((uint32_t)start << 16) | ((uint32_t)count_minus_one + 1);
}
----------------
Huh, your compiler warns when widening a unsigned byte to an unsigned int?
Interesting.
http://reviews.llvm.org/D4315
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
