On Thu, Jun 26, 2014 at 11:57 AM, Richard Smith <[email protected]>
wrote:
> ================
> Comment at: src/Unwind/Unwind-EHABI.cpp:213
> @@ -211,3 +212,3 @@
> uint32_t RegisterRange(uint8_t start, uint8_t count_minus_one) {
> - return (start << 16) | (count_minus_one + 1);
> + return ((uint32_t)start << 16) | ((uint32_t)count_minus_one + 1);
> }
> ----------------
> Nico Weber wrote:
> > Huh, your compiler warns when widening a unsigned byte to an unsigned
> int? Interesting.
> Both subexpressions of the `|` used to be of type `signed int`; the
> warning will be for converting the result of the `|` to `unsigned`.
>
Ah, right. Might be simpler to just add a u suffix to the two literals then.
>
> http://reviews.llvm.org/D4315
>
>
>
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
