Szelethus marked 2 inline comments as done. Szelethus added a comment. It looks like I won't be back in office until Monday, so I can't finish this one until then :(
>> but I haven't seen the current version of the checker crash due to pointer >> chasing. > > @NoQ saw quite a few crashes during evaluation, right? That doesn't sound any good. I'd be very interested in fixing those. Any plans to make some bugreports on bugzilla? >> This might be a little nit-picking, but I don't think the finds are false >> positive > > Well, yeah, it depends on how do you define things. If we define reports as > "bugs", then I guess this checker already does not find bugs, but > best-practices violations. > Then it can be argued whether "best practice" should be extended to include > all the memory reachable through pointers. Fair point. I still am very confident that pointer chasing should be a thing, but I strongly agree that it lacks good heuristics to make the reports more meaningful. https://reviews.llvm.org/D49438 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
