JonasToth added inline comments.

Comment at: clang-tidy/abseil/NoInternalDepsCheck.cpp:24
+  Finder->addMatcher(
+      nestedNameSpecifierLoc(loc(specifiesNamespace(namespaceDecl(
Actually that one is generally useful. Accessing the `foo::internal` from 
outside of `foo` is always a problem. Maybe this matcher can become 
configurable or just match on any `internal` access from outside the enclosing 

Comment at: clang-tidy/abseil/NoInternalDepsCheck.h:21
+/// against doing so.
+/// Should not run on internal Abseil files or Abseil source code.
Please make this a full sentence, like `This check should not be run on 
internal ...` (if that is grammatically correct)

  rCTE Clang Tools Extra

cfe-commits mailing list

Reply via email to