Eugene.Zelenko added inline comments.
================ Comment at: docs/ReleaseNotes.rst:58 + + Warns Abseil users if they attempt to depend on internal details. ---------------- I think will be good idea to omit user, and just refer to code which depend on internal details. Please synchronize with documentations. ================ Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:15 +} +class SomeContainer{}; + ---------------- Please separate with empty line. ================ Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:51 + + + ---------------- Please remove two empty lines https://reviews.llvm.org/D50542 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits