tekknolagi added inline comments.
================ Comment at: test/Analysis/padding_cpp.cpp:204-212 +// expected-warning@+1{{Excessive padding in 'struct FakeIntSandwich'}} +struct FakeIntSandwich { + char c1; + int i; + char c2; +}; + ---------------- tekknolagi wrote: > bcraig wrote: > > Looking at this again... what new cases does this catch? FakeIntSandwich > > was caught before (it is identical to 'PaddedA', and AnotherIntSandwich > > generated no warning before. So what is different? > > > > EBO1 and EBO2 are cases above that would be nice to catch, but aren't being > > caught right now. > Ah, you're right. I'll just keep the one in `padding_inherit`. @bcraig I updated the description of the diff to be more informative about the particular cases this change catches. Repository: rC Clang https://reviews.llvm.org/D53206 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits