ZaMaZaN4iK added inline comments.
================
Comment at: StaticAnalyzer/Core/CMakeLists.txt:43
PlistDiagnostics.cpp
+ SarifDiagnostics.cpp
ProgramState.cpp
----------------
Sort alphabetically
================
Comment at: StaticAnalyzer/Core/SarifDiagnostics.cpp:88
+ // URI encode the part.
+ for (char C : Component) {
+ // RFC 3986 claims alpha, numeric, and this handful of
----------------
I don't know about const corectness policy in LLVM. But I prefer here const
char C .
================
Comment at: StaticAnalyzer/Core/SarifDiagnostics.cpp:94
+ // reserved character.
+ if (llvm::isAlnum(C) ||
+ StringRef::npos !=
----------------
Probably this piece of code will be better to write separately as function
https://reviews.llvm.org/D53814
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
