NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land.
I'm seeing no problems with this patch and i'm happy that we're replacing hacks with well-defined patterns :) In D54438#1322970 <https://reviews.llvm.org/D54438#1322970>, @Szelethus wrote: > - Register the checker after it's dependencies (accidentally left this change > in the next branch). This implies that `unix.MallocChecker:Optimistic` is no > longer a thing, and is now called `unix.DynamicMemoryModeling:Optimistic`. > This //could// break backward compatibility, but is also addressable, since > it can always be converted to whatever full name `DynamicMemoryModeling` will > have in the future. @george.karpenkov @NoQ feelings on this? I believe nobody uses this flag, feel free to remove it entirely. In D54438#1322970 <https://reviews.llvm.org/D54438#1322970>, @Szelethus wrote: > - In `test/Analysis/Inputs/expected-plists/nullability-notes.m.plist`, the > name of the checker associated with a report changed, but this is **NOT** an > issue raised by this patch -- simply changing the order of > `analyzer-checker=ABC,CBA` to `CBA,ABC` will cause the same issue. Please > don't mind me, but I'm not immediately interested in fixing this issue. It wasn't correct in the first place (should have been `NullablePassedToNonnull` instead). Anyway, no problem! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54438/new/ https://reviews.llvm.org/D54438 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
