rjmccall added inline comments.

================
Comment at: clang/lib/AST/ExprConstant.cpp:3441
+                                  Value);
+    }
     APSInt LHS = HandleIntToIntCast(Info, E, PromotedLHSType,
----------------
Can we more fundamentally restructure this entire handler so that, if the 
compound assignment's computation result type is an arithmetic type, we just 
promote both operands to that type, do the arithmetic there, and then coerce 
back down?  This is C++, so the LHS type imposes almost no restrictions on the 
RHS type; also, this is Clang, where we support way too many arithmetic types 
for our own good.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55413/new/

https://reviews.llvm.org/D55413



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to