cpplearner marked 2 inline comments as done. cpplearner added inline comments.
================ Comment at: clang/lib/AST/ExprConstant.cpp:3453 Value) && handleFloatFloatBinOp(Info, E, Value, Opcode, RHS.getFloat()) && HandleFloatToFloatCast(Info, E, PromotedLHSType, SubobjType, Value); ---------------- rjmccall wrote: > rsmith wrote: > > Does this work for the float += int case? > IIRC, the RHS gets promoted to the computation type in Sema. Yes, in the float += int case, the RHS is the result of ImplicitCastExpr of kind IntegralToFloating. And `test_float()` contains test for that case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55413/new/ https://reviews.llvm.org/D55413 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits