krytarowski added inline comments.
================ Comment at: lib/xray/xray_basic_logging.cc:58 -struct alignas(64) ThreadLocalData { +struct +/* TLD is not aligned properly on NetBSD, resulting in segfault */ ---------------- Can we introduce a macro like: ``` #if SANITIZER_NETBSD #define XRAY_TLS_ALIGNAS64 /* Nor supported */ #else #define XRAY_TLS_ALIGNED_SUPPORTED #define XRAY_TLS_ALIGNAS64 alignas(64) #endif ``` And later: ``` struct XRAY_TLS_ALIGNAS64 ThreadLocalData { ``` and ``` #ifdef XRAY_TLS_ALIGNED_SUPPORTED static_assert(alignof(ThreadLocalData) >= 64, "ThreadLocalData must be cache line aligned."); #endif ``` Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56000/new/ https://reviews.llvm.org/D56000 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits