dberris added inline comments.
================ Comment at: lib/xray/xray_defs.h:22 +#if !SANITIZER_NETBSD +#define XRAY_TLS_ALIGNAS(x) alignas(x) ---------------- krytarowski wrote: > I would switch the order, in order to remove unneeded negation. > > ``` > #if SANITIZER_NETBSD > ... > #else > ... > #endif > ``` > > `#define XRAY_HAS_TLS_ALIGNAS 0` is not needed as `#if XRAY_HAS_TLS_ALIGNAS` > will evaluate to false anyway and `#define XRAY_HAS_TLS_ALIGNAS 1` is > equivalent to `#define XRAY_HAS_TLS_ALIGNAS`. But it's just a matter of style. FWIW, I agree to this suggestion. I also prefer: ``` #if SANITIZER_NETBSD ... #else ... ``` But I do like the explicit definition of `XRAY_HAS_TLS_ALIGNAS`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56000/new/ https://reviews.llvm.org/D56000 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
