a_sidorin added a comment.
Hi Rafael,
The change looks mostly fine but I have some comments inline.
================
Comment at: lib/AST/ASTImporter.cpp:3243
+
+ if (R) {
+ CXXDestructorDecl *ToDtor = cast<CXXDestructorDecl>(*R);
----------------
It's better to move this code to VisitFunctionDecl to keep all related stuff
together.
================
Comment at: lib/AST/ASTImporter.cpp:3246
+
+ auto Imp = importSeq(const_cast<FunctionDecl *>(D->getOperatorDelete()),
+ D->getOperatorDeleteThisArg());
----------------
Moving this code to VisitFunctionDecl will also allow us not to create a dtor
if this import fails.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56651/new/
https://reviews.llvm.org/D56651
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
