tlively added inline comments.
================ Comment at: lib/Driver/ToolChains/WebAssembly.cpp:29 + Pthread = + DriverArgs.hasFlag(options::OPT_pthread, options::OPT_no_pthread, false); + ThreadModel = ---------------- aheejin wrote: > tlively wrote: > > Shouldn't every use of `hasFlag` be `getLastArgValue` instead? > `hasFlag` is a convenient way to check everything with one function call. > with `getLastArgValue` we have to call it twice (for example, for `-pthread` > and for `-no-pthread`), and most importantly when both of them are given, > calling `getLastArgValue` doesn't give you information on which one is the > last. `hasFlag` takes care of that by taking the last one when both of them > are given. So `-pthread -no-pthread` will return false, and `-no-pthread > -pthread` will return true. > > The reason I used `hasArg` below is just to check if the user gave it > explicitly or not. And that's the reason I named variables `Pthread` and > `HasPthread`. I see! I had misunderstood hasFlag. Thanks for explaining it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57874/new/ https://reviews.llvm.org/D57874 _______________________________________________ cfe-commits mailing list firstname.lastname@example.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits