vsapsai marked an inline comment as done.
vsapsai added inline comments.

================
Comment at: clang/lib/Lex/HeaderSearch.cpp:388
   } else {
     Result = HS.getFileMgr().getFile(Dest);
   }
----------------
I have considered changing this to `.getFile(Dest, /*OpenFile=*/true)` so that 
the bug can be triggered without a double include. But decided not to do so 
because it seems weird to open a file (and make an extra syscall) to make it 
easier to ignore the filename case mismatch later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58094/new/

https://reviews.llvm.org/D58094



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to