jakehehrlich added a comment.

This shouldn't emit the .tbe format at all, the .tbe format is meant to be in 
near 1-1 correspondence with .so files, not with .o files. It has things like 
DT_NEEDED, and DT_SONAME related information that don't make sense for .o files 
for instance.

If we put things under an --experimental flags, minimize what we add in the 
first patch, and try and make each additional field added need based, I'm ok 
with whatever being added to Clang assuming it doesn't interfere with other 
parts of the compiler.



================
Comment at: llvm/include/llvm/TextAPI/ELF/ELFStub.h:58
   ELFArch Arch;
+  Optional<std::string> Endian;
   std::vector<std::string> NeededLibs;
----------------
Why do we need or want this? If it is needed can it be added later when needed? 
Also why is this a string?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to