djtodoro marked an inline comment as done.
djtodoro added inline comments.
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:3885
+ if (ArgNo) {
+ auto *PD = dyn_cast<ParmVarDecl>(VD);
+ ParmCache[PD].reset(D);
----------------
aprantl wrote:
> A `dyn_cast` followed by an unconditional use seems strange. I would expect
> either a `cast` or an `if (PD)` check.
Yes, thanks for this!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58035/new/
https://reviews.llvm.org/D58035
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
