jcai19 marked 2 inline comments as done. jcai19 added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:9 + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: prefer pipe2() to pipe() because pipe2() allows O_CLOEXEC [android-cloexec-pipe] + // CHECK-FIXES: pipe2(pipefd, O_CLOEXEC); +} ---------------- george.burgess.iv wrote: > (Do we have a CHECK-FIXES-NOT or CHECK-MESSAGES-NOT to apply to the things > below? Or are the CHECKs here meant to be complete like clang's `-verify`?) Based on Testing Checks https://clang.llvm.org/extra/clang-tidy/Contributing.html, CHECK-MASSAGES and CHECK-FIXES are sufficient for clang-tidy checks. I have double checked the tests for similar checks and they don't seem to have additional FileCheck invocations other than these two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
