srhines added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:17 + pipe(pipefd); + // CHECK-MESSAGES-NOT: warning: +} ---------------- hokein wrote: > nit: no need to do it explicitly, if a warning is shown unexpectedly, the > test will fail. I somehow never realized this (and there seem to be several places that also don't realize it). Thanks for letting us know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
