aaron.ballman added a comment.
In D61508#1509368 <https://reviews.llvm.org/D61508#1509368>, @trixirt wrote:
> Latest change addresses most of issues.
> Outstanding is adding a test when garbage GuardStyle value is fed into
> config.
> The trial testcase used only CHECK-*-NOT which caused complaining from test
> harness looking for the CHECK- cases.
> Looking for something similar in the other checker tests did not turn up
> anything.
> In general it seems like clang-tidy assumes developers get the string names
> of the options and their values correct and does not provide a lot of (any?)
> checking.
We're probably quite inconsistent in this regard, and it seems like something
we may want to address across the board (not suggesting that you have to fix
it, or even as part of this patch). I was envisioning the test as being
something like `CHECK-MESSAGES-ERROR: 1:1: error: %s is an unsupported header
guard style` or something along those lines.
================
Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30
+}
+std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename,
+ StringRef OldGuard) {
----------------
Can you add a newline for some visual separation?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61508/new/
https://reviews.llvm.org/D61508
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
