aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.


================
Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30
+}
+std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename,
+                                                     StringRef OldGuard) {
----------------
trixirt wrote:
> aaron.ballman wrote:
> > Can you add a newline for some visual separation?
> I did not think ment a empty newline in the param-list, so  I assumed you 
> ment the function above and this function could use a new line.  
You guessed correctly -- sorry for the lack of clarity. :-)


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61508/new/

https://reviews.llvm.org/D61508



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to